Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Make some methods of ClusterBase pure async. #15437

Merged
merged 10 commits into from
May 13, 2022
Merged

[improve][broker] Make some methods of ClusterBase pure async. #15437

merged 10 commits into from
May 13, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

See PIP #14365 and change tracker #15043.

Modifications

  • Make ClusterBase getNamespaceIsolationPolicies / getNamespaceIsolationPolicy / getBrokersWithNamespaceIsolationPolicy

Verifying this change

  • Make sure that the change passes the CI checks.

AdminApi2Test#brokerNamespaceIsolationPolicies and AdminTest#clusters already cover this change.

Documentation

  • no-need-doc
    (Please explain why)

@mattisonchao mattisonchao marked this pull request as draft May 4, 2022 21:40
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 4, 2022
@mattisonchao mattisonchao mentioned this pull request May 4, 2022
Closed
26 tasks
@mattisonchao mattisonchao marked this pull request as ready for review May 10, 2022 03:18
@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels May 11, 2022
@Technoboy- Technoboy- added this to the 2.11.0 milestone May 11, 2022
gaoran10
gaoran10 approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shibd
shibd approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@shibd shibd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@mattisonchao mattisonchao merged commit aa03ccd into apache:master May 13, 2022
@mattisonchao mattisonchao deleted the pip_149_5 branch May 13, 2022 03:11
@sijie sijie mentioned this pull request Aug 1, 2022
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@shibd shibd shibd approved these changes

@eolivelli eolivelli Awaiting requested review from eolivelli

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@mattisonchao mattisonchao

Labels
area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mattisonchao @Technoboy- @gaoran10 @shibd