[improve][broker] Make some operation messageTTL methods in Namespaces async. #15577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shibd:Thanks for your contribution. For this PR, do we need to update docs? |
shibd
changed the title
shibd
changed the title
shibd
changed the title
shibd
force-pushed
the
async_ttl_namespace
branch
from
2e7d7df to
139b485
Compare
shibd
force-pushed
the
async_ttl_namespace
branch
from
139b485 to
2769bc2
Compare
|
/pulsarbot run-failure-checks |
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
reviewed
May 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
Show resolved
Hide resolved
Technoboy-
added
area/admin
doc-not-needed
|
@Technoboy- Thanks for your review, all log added. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Technoboy-
added
the
type/enhancement
codelipenghui
approved these changes
May 18, 2022
lhotari
added a commit
to lhotari/pulsar
that referenced
this pull request
May 18, 2022
…amespaces async. (apache#15577)" This reverts commit 7c50674.
26 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make NamespacesBase
getNamespaceMessageTTL / setNamespaceMessageTTL / removeNamespaceMessageTTLmethods to pure async.Documentation