Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][doc] Add docs for how to change Pulsar configs in Docker #16085

Merged
merged 3 commits into from
Jun 17, 2022
Merged

[improve][doc] Add docs for how to change Pulsar configs in Docker #16085

merged 3 commits into from
Jun 17, 2022

Conversation

momo-jun
Copy link
Contributor

@momo-jun momo-jun commented Jun 16, 2022 •
edited
Loading

Modifications

  1. Add docs for how to change Pulsar configs in Docker. --- fix this issue [Doc] docker improvments #15972
  2. Minor fixes in the Get Started topic.

The preview looks good.
image

Documentation

  • doc

@momo-jun momo-jun marked this pull request as ready for review June 16, 2022 06:45
@momo-jun
Copy link
Contributor Author

Ping @zymap @Anonymitaet for review.

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jun 16, 2022
zymap
zymap approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zymap zymap requested a review from Anonymitaet June 17, 2022 02:30
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone Jun 17, 2022
@Anonymitaet Anonymitaet merged commit 3db46c3 into apache:master Jun 17, 2022
@kiview kiview mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zymap zymap zymap approved these changes

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@michaeljmarshall michaeljmarshall Awaiting requested review from michaeljmarshall

Assignees

@momo-jun momo-jun

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@momo-jun @zymap @Anonymitaet