[fix][broker]stage 1: check the cursor status when handling flowPermits #16546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HQebupt
force-pushed
the
resetCursorInProgress
branch
from
5cc8392 to
2d5627b
Compare
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
...va/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java
Outdated
Show resolved
Hide resolved
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
codelipenghui
added
type/bug
HQebupt
changed the title
|
/pulsarbot run-failure-checks |
7 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
HQebupt
force-pushed
the
resetCursorInProgress
branch
from
fb274c8 to
fd05b8d
Compare
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
|
@HQebupt Please fix CI failure. |
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
|
@HQebupt hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks. |
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16757
Motivation
also fixes #14559
Readerbelongs to exclusive subscription type, and it usesnonDurablecursor. After receiving messages,Readerwill ack cumulatively immediately.The
flowPermitsare triggered in multiple scenarios from the client side and it is isolated fromseekofConsumer. Therefore, it is possibile thatflowPermitswill execute afterseekfrom the client side, like the following flow chart.When
handleSeekprocessing is delay from the server side, theMarkDelete positionis modified in a wrong way.The expected result is that
Readercan re-consume messages frommark delete:(1,1)afterseek. But it doesn't work.Modifications
flowPermitsfrom the server side.ConsumerImpl, in which prevent an in-process entry reading operation after the seek position@codelipenghui
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-not-needed