-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix broken build caused by conflict between #17195 and #16605 #17300
Merged
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-fix-broken-master-sendMessage
Aug 26, 2022
Merged
[fix][broker] Fix broken build caused by conflict between #17195 and #16605 #17300
lhotari
merged 1 commit into
apache:master
from
lhotari:lh-fix-broken-master-sendMessage
Aug 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and apache#16605 - apache#17195 changed the method signature that apache#16605 depended upon
lhotari
added
type/bug
The PR fixed a bug or issue reported a bug
component/client-java
doc-not-needed
Your PR changes do not impact docs
labels
Aug 26, 2022
nicoloboschi
approved these changes
Aug 26, 2022
1 task
eolivelli
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jason918
approved these changes
Aug 26, 2022
HQebupt
approved these changes
Aug 26, 2022
liangyuanpeng
approved these changes
Aug 26, 2022
codelipenghui
approved these changes
Aug 26, 2022
michaeljmarshall
approved these changes
Aug 26, 2022
congbobo184
approved these changes
Aug 26, 2022
AnonHxy
approved these changes
Aug 26, 2022
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
doc-not-needed
Your PR changes do not impact docs
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
master branch is broken.
Modifications
null
to new argument introduced by [feat][client]PIP-180 ShadowTopic - Part II - Add support for messgae_id in CommandSend #17195doc-not-needed