Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][broker] Improve replicatorDispacherRate endpoint to pure async. #17377

Merged
merged 4 commits into from
Sep 2, 2022
Merged

[Improve][broker] Improve replicatorDispacherRate endpoint to pure async. #17377

merged 4 commits into from
Sep 2, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

Since Pulsar is a fully asynchronous project, we need to avoid using thread-blocking methods.

Also, we can see #14365

Modifications

  • Improve replicatorDispacherRate relative endpoint to pure async.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@mattisonchao mattisonchao added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Aug 31, 2022
@mattisonchao mattisonchao self-assigned this Aug 31, 2022
@github-actions
Copy link

@mattisonchao Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@Technoboy- Technoboy- added this to the 2.12.0 milestone Sep 1, 2022
@mattisonchao mattisonchao merged commit 305758a into apache:master Sep 2, 2022
@mattisonchao mattisonchao deleted the pip_149_11 branch September 2, 2022 07:50
nodece pushed a commit to nodece/pulsar that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin doc-label-missing type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants