[improve][test] Add test brokerReachThreshold for ThresholdShedderTest
#18664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Nov 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #18664 +/- ##
============================================
+ Coverage 47.06% 47.39% +0.32%
- Complexity 8956 10491 +1535
============================================
Files 592 698 +106
Lines 56313 68062 +11749
Branches 5844 7276 +1432
============================================
+ Hits 26503 32255 +5752
- Misses 26946 32208 +5262
- Partials 2864 3599 +735
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
changed the title
brokerReachThreshold for ThresholdShedderTestbrokerReachThreshold for ThresholdShedderTest
mattisonchao
approved these changes
Nov 29, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Technoboy-
added a commit
that referenced
this pull request
Mar 6, 2023
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 23, 2024
…est (apache#18664) (cherry picked from commit 58ad3d0)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 24, 2024
…est (apache#18664) (cherry picked from commit 58ad3d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
More details are here #18598, so add this test to avoid regression.
Documentation
docdoc-requireddoc-not-neededdoc-complete