-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] [broker] Add broker health check status into prometheus metrics #20147
Conversation
@vineeth1995 Please select only one documentation label in your PR description. |
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20147 +/- ##
============================================
+ Coverage 73.57% 74.51% +0.94%
- Complexity 32624 34551 +1927
============================================
Files 1877 1937 +60
Lines 139502 145459 +5957
Branches 15299 15898 +599
============================================
+ Hits 102638 108395 +5757
+ Misses 28908 28743 -165
- Partials 7956 8321 +365
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/BrokerOperabilityMetrics.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/BrokerStats.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @vineeth1995
If I remember correctly, the new configuration should draft a proposal.
Refer to: https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md
@mattisonchao |
f74cf57
to
8216576
Compare
@mattisonchao I have addressed the changes. Can you please unblock the PR? |
Hi, @rdhabalia |
Sure.
@mattisonchao but this PR was blocked with reason of configuration change so, I mentioned that it was not part of PIP doc. |
Ohh, I see. Thanks! |
The pr had no activity for 30 days, mark with Stale label. |
PIP has been approved: #20389 |
50bb381
to
29f77e9
Compare
29f77e9
to
84c4a3e
Compare
Motivation
Issue: #20146
To add broker health check into prometheus metric.
Modifications
Schedule a job at 1 minute time interval which calls healthCheck API on broker and updates the pulsar stats based on the broker health.
Verifying this change
Unit test cases were added to verify this change.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete