-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][build] Capture local build scans on ge.apache.org to benefit from deep build insights #20187
[improve][build] Capture local build scans on ge.apache.org to benefit from deep build insights #20187
Conversation
With updates in Gradle Enterprise Maven Extension 1.17, the `publishIfAuthenticated` configuration will silently not publish a build scan if the user is not authenticated to https://ge.apache.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I'm thinking of further cleanup for setting:
env:
GRADLE_ENTERPRISE_ACCESS_KEY: ...
and drop the handmade action, it should not be a blocker to us for merging this patch.
Codecov Report
@@ Coverage Diff @@
## master #20187 +/- ##
============================================
+ Coverage 72.25% 72.92% +0.66%
+ Complexity 31952 31858 -94
============================================
Files 1855 1868 +13
Lines 138267 138468 +201
Branches 15222 15236 +14
============================================
+ Hits 99901 100973 +1072
+ Misses 30386 29460 -926
- Partials 7980 8035 +55
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merging... |
Motivation
This PR publishes a build scan for every CI build on GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.
The build scans of the Apache Pulsar project are published to the Gradle Enterprise instance at ge.apache.org, hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Pulsar project and all other Apache projects.
Currently, the Apache Pulsar build is configured to publish build scans to ge.apache.org for CI only. This pull request enhances that functionality by also publishing build scans to ge.apache.org for authenticated Apache committers. On this Gradle Enterprise instance, Apache Pulsar will have access not only to all of the published build scans but other aggregate data features such as:
Modifications
ge-extensions.xml
in favor of the more conventionalextensions.xml
file. Updates to thepublishIfAuthenticated
property in Gradle Enterprise Maven Extension 1.17 will cause the build to print no output if the user is not authenticated to ge.apache.org.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: