Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][ci] Update nar maven plugin version to fix excessive downloads #20410

Merged
merged 1 commit into from
May 26, 2023
Merged

[fix][ci] Update nar maven plugin version to fix excessive downloads #20410

merged 1 commit into from
May 26, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 26, 2023

Motivation

Building the pulsar-all docker image is very slow. Most of the time is spent in nar file creation.

Modifications

Update nar maven plugin to 1.5.0

Contains fixes such as

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.1.0 milestone May 26, 2023
@lhotari lhotari self-assigned this May 26, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 26, 2023
@lhotari lhotari mentioned this pull request May 26, 2023
Closed
4 tasks
@lhotari
Copy link
Member Author

lhotari commented May 26, 2023

This seems to help with the building of the pulsar-all docker image in CI. In this PR builds, it took 34 minutes to build the docker image. I compared to another build where it took 42 minutes and one where it timed out at 1 hour.

@nicoloboschi nicoloboschi merged commit 795eb51 into apache:master May 26, 2023
eolivelli
eolivelli reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

lhotari added a commit that referenced this pull request May 29, 2023
@lhotari
[fix][ci] Update nar maven plugin version to fix excessive downloads (#…
d8876d5 
…20410)

(cherry picked from commit 795eb51)
lhotari added a commit that referenced this pull request May 29, 2023
@lhotari
[fix][ci] Update nar maven plugin version to fix excessive downloads (#…
e3be9e7 
…20410)

(cherry picked from commit 795eb51)
lhotari added a commit that referenced this pull request May 29, 2023
@lhotari
[fix][ci] Update nar maven plugin version to fix excessive downloads (#…
42d9aa5 
…20410)

(cherry picked from commit 795eb51)
lhotari added a commit to datastax/pulsar that referenced this pull request May 29, 2023
@lhotari
[fix][ci] Update nar maven plugin version to fix excessive downloads (a…
444ce53 
…pache#20410)

(cherry picked from commit 795eb51)
(cherry picked from commit d8876d5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli left review comments

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@cbornet cbornet Awaiting requested review from cbornet

@tisonkun tisonkun Awaiting requested review from tisonkun

@dave2wave dave2wave Awaiting requested review from dave2wave

Assignees

@lhotari lhotari

Labels
area/ci cherry-picked/branch-2.10 cherry-picked/branch-2.11 cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.10.5 release/2.11.2 release/3.0.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lhotari @eolivelli @nicoloboschi