Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [admin] set ns level backlog quota does not take effect if retention exists #20690

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Jun 30, 2023

Motivation

When a retention policy exists, the command pulsar-admin namespaces set-backlog-quota does not take effect.

In the PR #17383: it only checked the compatibility of retention and backlog quota, and it was not set.

Modifications

Fix the bug.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@github-actions
Copy link

@poorbarcode Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@poorbarcode poorbarcode changed the title [fix] [admin] set ns level backlog quota does not take effect if rete [fix] [admin] set ns level backlog quota does not take effect if retention exists Jun 30, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 30, 2023
@poorbarcode poorbarcode self-assigned this Jun 30, 2023
@poorbarcode poorbarcode added type/bug The PR fixed a bug or issue reported a bug area/admin labels Jun 30, 2023
@poorbarcode poorbarcode added this to the 3.1.0 milestone Jun 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20690 (b86c60a) into master (0e60340) will increase coverage by 0.50%.
The diff coverage is 83.97%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20690      +/-   ##
============================================
+ Coverage     72.60%   73.10%   +0.50%     
- Complexity    32018    32059      +41     
============================================
  Files          1855     1869      +14     
  Lines        138569   138848     +279     
  Branches      15250    15271      +21     
============================================
+ Hits         100605   101502     +897     
+ Misses        29945    29290     -655     
- Partials       8019     8056      +37     
Flag Coverage Δ
inttests 24.08% <45.85%> (-0.03%) ⬇️
systests 24.99% <24.86%> (?)
unittests 72.38% <83.97%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ar/common/naming/TopicBundleAssignmentFactory.java 66.66% <66.66%> (ø)
.../metadata/bookkeeper/PulsarRegistrationClient.java 80.85% <81.11%> (-4.11%) ⬇️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 62.55% <86.95%> (+0.63%) ⬆️
.../java/org/apache/pulsar/client/cli/CmdProduce.java 52.47% <88.00%> (+3.84%) ⬆️
...org/apache/pulsar/broker/ServiceConfiguration.java 99.38% <100.00%> (+<0.01%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 72.26% <100.00%> (+0.38%) ⬆️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 64.66% <100.00%> (+0.05%) ⬆️
...n/naming/ConsistentHashingTopicBundleAssigner.java 100.00% <100.00%> (ø)
...e/pulsar/common/naming/NamespaceBundleFactory.java 77.04% <100.00%> (+0.25%) ⬆️
.../apache/pulsar/common/naming/NamespaceBundles.java 79.74% <100.00%> (-0.98%) ⬇️
... and 1 more

... and 143 files with indirect coverage changes

@poorbarcode poorbarcode merged commit 6acd01d into apache:master Jun 30, 2023
70 of 78 checks passed
@poorbarcode poorbarcode deleted the fix/set_ns_backlog_quota branch June 30, 2023 06:43
poorbarcode added a commit that referenced this pull request Jun 30, 2023
…ntion exists (#20690)

Motivation: When a retention policy exists, the command `pulsar-admin namespaces set-backlog-quota` does not take effect.In the PR #17383: it only checked the compatibility of `retention` and `backlog quota`, and it was not set.

Modifications: Fix the bug.
(cherry picked from commit 6acd01d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants