[improve] [client] Merge lookup requests for the same topic #21232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
Technoboy-,
codelipenghui,
michaeljmarshall and
heesung-sn
poorbarcode
added
release/2.10.6
release/3.0.2
release/2.11.3
category/reliability
heesung-sn
approved these changes
Sep 22, 2023
Demogorgon314
approved these changes
Sep 22, 2023
coderzc
approved these changes
Sep 22, 2023
AnonHxy
reviewed
Sep 22, 2023
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
Show resolved
Hide resolved
AnonHxy
approved these changes
Sep 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #21232 +/- ##
============================================
+ Coverage 72.73% 73.22% +0.48%
- Complexity 32465 32506 +41
============================================
Files 1875 1887 +12
Lines 139929 140138 +209
Branches 15413 15428 +15
============================================
+ Hits 101781 102616 +835
+ Misses 30067 29438 -629
- Partials 8081 8084 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
approved these changes
Sep 22, 2023
poorbarcode
added a commit
that referenced
this pull request
Sep 24, 2023
Motivation: Multiple consumers and producers can be maintained by the same Pulsar Client. In some cases, multiple consumers or producers might attempt to connect to the same topic. To optimize the process, it is recommended to perform the topic lookup only once for each topic. Modifications: - Merge lookup requests for the same topic. - Merge get partitioned metadata request for the same partitioned topic. (cherry picked from commit be4ab66)
poorbarcode
added a commit
that referenced
this pull request
Sep 24, 2023
Motivation: Multiple consumers and producers can be maintained by the same Pulsar Client. In some cases, multiple consumers or producers might attempt to connect to the same topic. To optimize the process, it is recommended to perform the topic lookup only once for each topic. Modifications: - Merge lookup requests for the same topic. - Merge get partitioned metadata request for the same partitioned topic. (cherry picked from commit be4ab66)
poorbarcode
added a commit
that referenced
this pull request
Sep 24, 2023
Motivation: Multiple consumers and producers can be maintained by the same Pulsar Client. In some cases, multiple consumers or producers might attempt to connect to the same topic. To optimize the process, it is recommended to perform the topic lookup only once for each topic. Modifications: - Merge lookup requests for the same topic. - Merge get partitioned metadata request for the same partitioned topic. (cherry picked from commit be4ab66)
Technoboy-
pushed a commit
that referenced
this pull request
Sep 25, 2023
Motivation: Multiple consumers and producers can be maintained by the same Pulsar Client. In some cases, multiple consumers or producers might attempt to connect to the same topic. To optimize the process, it is recommended to perform the topic lookup only once for each topic. Modifications: - Merge lookup requests for the same topic. - Merge get partitioned metadata request for the same partitioned topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Multiple consumers and producers can be maintained by the same Pulsar Client. In some cases, multiple consumers or producers might attempt to connect to the same topic. To optimize the process, it is recommended to perform the topic lookup only once for each topic.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x