Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test] Fix thread leak in concurrent collections tests #21449

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 26, 2023

Motivation

Concurrent collections tests continue to leak threads.

Modifications

  • replace while (true) with while (!Thread.currentThread().isInterrupted()) so that the thread has a chance to exit when the thread pool is shutdown.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Oct 26, 2023
@lhotari lhotari self-assigned this Oct 26, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21449 (09d0426) into master (2b5c199) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21449      +/-   ##
============================================
- Coverage     73.31%   73.28%   -0.04%     
- Complexity    32599    32606       +7     
============================================
  Files          1890     1890              
  Lines        140357   140357              
  Branches      15425    15425              
============================================
- Hits         102903   102856      -47     
- Misses        29361    29416      +55     
+ Partials       8093     8085       -8     
Flag Coverage Δ
inttests 24.29% <ø> (+0.06%) ⬆️
systests 24.82% <ø> (+0.03%) ⬆️
unittests 72.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 76 files with indirect coverage changes

@lhotari lhotari merged commit b5ac129 into apache:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants