Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-313 Support force unsubscribe using consumer api #21452

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Oct 27, 2023

Fixes #21451

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia self-assigned this Oct 27, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 27, 2023
@liudezhi2098
Copy link
Contributor

Whether it would be more appropriate to add automatic cleaning subscribers, similar to automatically deleting inactive topics?

@rdhabalia
Copy link
Contributor Author

Whether it would be more appropriate to add automatic cleaning subscribers, similar to automatically deleting inactive topics?

Inactive topic doesn't have any sub but here in this case, when pulsar spout tries to unsubscribe on a shared sub, unsubscribe request fails first and it will also not close the consumer. so, in this case, both sub and consumer are still live and we should not perform any auto cleanup on such uncertain state.

@@ -0,0 +1,74 @@
# PIP-313: Support force unsubscribe using consumer api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filename should be pip-313.md

Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the vote thread link

@Technoboy- Technoboy- added this to the 3.2.0 milestone Dec 11, 2023
@Technoboy- Technoboy- merged commit c34a5d8 into apache:master Dec 15, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar spout fails to unsubscribe and close consumers on a shared subscription
5 participants