-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-313 Support force unsubscribe using consumer api #21452
Conversation
Whether it would be more appropriate to add automatic cleaning subscribers, similar to automatically deleting inactive topics? |
Inactive topic doesn't have any sub but here in this case, when pulsar spout tries to unsubscribe on a shared sub, unsubscribe request fails first and it will also not close the consumer. so, in this case, both sub and consumer are still live and we should not perform any auto cleanup on such uncertain state. |
@@ -0,0 +1,74 @@ | |||
# PIP-313: Support force unsubscribe using consumer api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filename should be pip-313.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the vote thread link
Fixes #21451
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: