Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Add optional parameters for getPartitionedStats #21611

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

crossoverJie
Copy link
Member

PIP: #21228

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:
https://github.com/crossoverJie/pulsar/blob/c97cdf3d535e90cb725cbf6016cc8ecc2570ce9a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest.java#L1050-L1130

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: crossoverJie#17

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 22, 2023
@Technoboy- Technoboy- changed the title [improve][broker][client] Implement PIP-303 [improve][broker] Add optional parameters for getPartitionedStats Nov 27, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Nov 27, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #21611 (c97cdf3) into master (98bf9dd) will increase coverage by 36.55%.
Report is 13 commits behind head on master.
The diff coverage is 84.70%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21611       +/-   ##
=============================================
+ Coverage     36.75%   73.31%   +36.55%     
- Complexity    12215    32744    +20529     
=============================================
  Files          1715     1893      +178     
  Lines        131076   140732     +9656     
  Branches      14314    15497     +1183     
=============================================
+ Hits          48182   103177    +54995     
+ Misses        76498    29446    -47052     
- Partials       6396     8109     +1713     
Flag Coverage Δ
inttests 24.12% <34.11%> (-0.06%) ⬇️
systests 24.68% <32.94%> (-0.24%) ⬇️
unittests 72.65% <84.70%> (+40.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pulsar/broker/admin/impl/PersistentTopicsBase.java 64.32% <100.00%> (+54.17%) ⬆️
...pache/pulsar/broker/admin/v1/PersistentTopics.java 51.40% <100.00%> (+41.23%) ⬆️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 62.67% <100.00%> (+34.89%) ⬆️
...pache/pulsar/broker/admin/v2/PersistentTopics.java 80.72% <100.00%> (+67.60%) ⬆️
...n/java/org/apache/pulsar/broker/service/Topic.java 36.36% <ø> (+27.27%) ⬆️
...rvice/nonpersistent/NonPersistentSubscription.java 52.76% <100.00%> (+24.48%) ⬆️
...ker/service/persistent/PersistentSubscription.java 76.85% <100.00%> (+26.46%) ⬆️
...rg/apache/pulsar/client/admin/GetStatsOptions.java 87.50% <100.00%> (+7.50%) ⬆️
...in/java/org/apache/pulsar/client/admin/Topics.java 77.50% <100.00%> (+45.00%) ⬆️
.../apache/pulsar/broker/service/GetStatsOptions.java 75.00% <75.00%> (ø)
... and 3 more

... and 1454 files with indirect coverage changes

@Technoboy- Technoboy- merged commit a832d29 into apache:master Nov 30, 2023
53 checks passed
RobertIndie pushed a commit to apache/pulsar-client-go that referenced this pull request Mar 5, 2024
### Motivation
To keep consistent with the Java client.

Releted PR: apache/pulsar#21611

### Modifications

Add `GetStatsOptions` params.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants