-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-323: Complete Backlog Quota Telemetry #21709
Conversation
This PIP is based on #19601 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nice proposal with a clear background, and easy to read.
Just left a few minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me.
Thanks for this pip.
File name should be pip-323 |
@Technoboy- What am I missing? |
Ah, sorry. |
Need to update the vote thread |
@Technoboy- Can you please merge this? The PIP vote approved it. |
Motivation
PIP-323 is introduced to fill the gap of backlog quota telemetry. It allows the user to know when a time-based backlog quota is about to exceed, and how many times it exceeded. It also adds backlog quota check duration metric allowing the user to configure the interval for that check based on data. Once this is implemented, the user can finally create and alert to know when a certain topic is about to exceed its defined backlog quota limit, alert on it, and using topic stats Admin API to grab the subscription name causing it.
Modifications
Adding PIP-323
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete