[improve][ci] Upgrade Gradle Enterprise maven extension version #22096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-upgrade-gradle-enterprise-client
branch
from
a6231d0 to
5af45db
Compare
poorbarcode
approved these changes
Feb 22, 2024
Technoboy-
approved these changes
Feb 22, 2024
asafm
reviewed
Feb 22, 2024
| @@ -22,7 +22,9 @@ | |||
| <gradleEnterprise | |||
| xmlns="https://www.gradle.com/gradle-enterprise-maven" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:schemaLocation="https://www.gradle.com/gradle-enterprise-maven https://www.gradle.com/schema/gradle-enterprise-maven.xsd"> | |||
| <enabled>#{env['GRADLE_ENTERPRISE_ACCESS_KEY']?.trim() > ''}</enabled> | |||
| <!-- Enable Gradle Enterprise extension when GRADLE_ENTERPRISE_ACCESS_KEY is set and the build isn't | |||
There was a problem hiding this comment.
I would expand the comment after with:
GITHUB_HEAD_REF contains the name of the branch.
The regular expression:
- `(?i)` - This flag makes the matching case insensitive.
I would rewrite the comment for clarity:
<!-- Enable Gradle Enterprise extension when all of the following conditions match:
1. GRADLE_ENTERPRISE_ACCESS_KEY is set
2. The branch or repository names do not denote work in progress. In effect, it does not contain either "wip," "experiment," or "private."
-->
There was a problem hiding this comment.
I agree, this got already merged so I won't bother making further changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete