Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][ml]Expose ledger timestamp #22338

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Mar 25, 2024

Fixes #22312

Motivation

Modifications

see #22312

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dao-jun dao-jun self-assigned this Mar 25, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 25, 2024
@dao-jun dao-jun added release/3.0.5 release/3.1.5 release/3.2.3 and removed doc-not-needed Your PR changes do not impact docs labels Mar 25, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Mar 25, 2024
@dao-jun dao-jun closed this Mar 25, 2024
@dao-jun dao-jun reopened this Mar 25, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 25, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.74%. Comparing base (bbc6224) to head (44cd4a0).
Report is 85 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22338      +/-   ##
============================================
+ Coverage     73.57%   73.74%   +0.17%     
+ Complexity    32624    32324     -300     
============================================
  Files          1877     1886       +9     
  Lines        139502   139439      -63     
  Branches      15299    15287      -12     
============================================
+ Hits         102638   102832     +194     
+ Misses        28908    28645     -263     
- Partials       7956     7962       +6     
Flag Coverage Δ
inttests 26.93% <0.00%> (+2.35%) ⬆️
systests 24.48% <0.00%> (+0.15%) ⬆️
unittests 72.99% <0.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kkeeper/mledger/impl/ManagedLedgerFactoryImpl.java 81.02% <0.00%> (-0.36%) ⬇️

... and 134 files with indirect coverage changes

@dao-jun dao-jun merged commit cd49def into apache:master Mar 27, 2024
50 checks passed
@dao-jun dao-jun deleted the dev/expose_ledger_timestamp branch March 27, 2024 06:20
lhotari pushed a commit that referenced this pull request Mar 27, 2024
lhotari pushed a commit that referenced this pull request Mar 27, 2024
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Apr 1, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
(cherry picked from commit cd49def)
(cherry picked from commit 5e95828)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
(cherry picked from commit cd49def)
(cherry picked from commit 5e95828)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
(cherry picked from commit cd49def)
(cherry picked from commit 5e95828)
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
(cherry picked from commit cd49def)
(cherry picked from commit 5e95828)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
(cherry picked from commit cd49def)
(cherry picked from commit 5e95828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose timestamp to ledger info
4 participants