Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][admin] Tenant AdminRoles can not contains whitespace in the beginning or end. #22450

Merged
merged 6 commits into from
May 27, 2024

Conversation

falser101
Copy link
Contributor

Fixes #21710

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 7, 2024
@falser101 falser101 changed the title [fix][admin]: Tenant AdminRole can not be blank or containsWhitespace [fix][admin] Tenant AdminRole can not be blank or containsWhitespace Apr 7, 2024
@falser101
Copy link
Contributor Author

please help review, thanks. @BewareMyPower @poorbarcode @codelipenghui @liangyepianzhou

@BewareMyPower BewareMyPower added this to the 3.3.0 milestone Apr 8, 2024
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fail to avoid test passing even if the call succeeds

@falser101 falser101 changed the title [fix][admin] Tenant AdminRole can not be blank or containsWhitespace [fix][admin] Tenant AdminRoles can not contains whitespace in the beginning or end. Apr 10, 2024
@falser101
Copy link
Contributor Author

please review, thanks. @BewareMyPower @poorbarcode @liangyepianzhou

BewareMyPower
BewareMyPower previously approved these changes Apr 11, 2024
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falser101
Copy link
Contributor Author

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
Signed-off-by: falser101 <zjf_0731@163.com>
Signed-off-by: falser101 <zjf_0731@163.com>
Signed-off-by: falser101 <zjf_0731@163.com>
@falser101
Copy link
Contributor Author

please help review @lhotari @liangyepianzhou

@BewareMyPower
Copy link
Contributor

I think it would be ready to merge if tests passed since all comments should be addressed.

@falser101
Copy link
Contributor Author

/test

@falser101
Copy link
Contributor Author

I think it would be ready to merge if tests passed since all comments should be addressed.

how to run test,it's waiting for status to be reported?

@BewareMyPower
Copy link
Contributor

Since you're the first-time contributor, the workflow requires a committer to click the Approve and Run tests button to trigger the CI. I have clicked it just now. So let's wait

@BewareMyPower
Copy link
Contributor

There are some failed tests, please check them.

@falser101
Copy link
Contributor Author

There are some failed tests, please check them.

ok.

@falser101
Copy link
Contributor Author

There are some failed tests, please check them.

resolved

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.21%. Comparing base (bbc6224) to head (1367c39).
Report is 303 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22450      +/-   ##
============================================
- Coverage     73.57%   73.21%   -0.36%     
- Complexity    32624    32902     +278     
============================================
  Files          1877     1890      +13     
  Lines        139502   141502    +2000     
  Branches      15299    15528     +229     
============================================
+ Hits         102638   103606     +968     
- Misses        28908    29903     +995     
- Partials       7956     7993      +37     
Flag Coverage Δ
inttests 27.41% <50.00%> (+2.83%) ⬆️
systests 24.62% <40.00%> (+0.30%) ⬆️
unittests 72.22% <100.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...g/apache/pulsar/broker/admin/impl/TenantsBase.java 96.68% <100.00%> (+0.23%) ⬆️

... and 356 files with indirect coverage changes

@falser101
Copy link
Contributor Author

@BewareMyPower help merge this pull requests,thanks

@BewareMyPower BewareMyPower merged commit aa230bc into apache:master May 27, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] You are able to add a blank string as a tenant admin
7 participants