Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [broker] [break config settings] Do not support disabling the scheduled task deduplicationSnapshotMonitor anymore #22480

Closed

Conversation

poorbarcode
Copy link
Contributor

Motivation

Related to #22479

Background

  • When a topic is loading up, it will wait for the deduplication recovery to be finished if deduplication is enabled.
    • users can enable deduplication on the broker level, namespace level or topic level.
  • There is a scheduled task to acknowledge messages for the deduplication cursor.

Issue
The broker has no way to disable Deduplication(users can enable this feature by broker.conf. brokerDeduplicationEnabled , namespace level policies, or topic level policies), so the broker should not provide a way to turn off this scheduled task deduplicationSnapshotMonitor.

Modifications

Do not support disabling the scheduled task deduplicationSnapshotMonitor.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Apr 11, 2024
@poorbarcode poorbarcode changed the title Fix/cursor read pos miss 3 [fix] [broker] [break config settings] Do not support disabling the scheduled task deduplicationSnapshotMonitor anymore Apr 11, 2024
@poorbarcode
Copy link
Contributor Author

Since there is another fix that triggers a new snapshot building after a topic is loaded, the current PR can be closed. See: https://github.com/apache/pulsar/pull/22479/files#diff-32e651dda4c98296475fd4e3cd322c76d6da3618c1013eda21c6b9033dec1bc1R190-R191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants