[fix] [broker] Fix nothing changed after removing dynamic configs #22673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui,
nodece and
Demogorgon314
poorbarcode
changed the title
|
/pulsarbot rerun-failure-checks |
Demogorgon314
approved these changes
May 8, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Outdated
Show resolved
Hide resolved
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
…ache#22673) (cherry picked from commit ada31a9)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…ache#22673) (cherry picked from commit ada31a9) (cherry picked from commit f2c4367)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 15, 2024
…ache#22673) (cherry picked from commit ada31a9)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…ache#22673) (cherry picked from commit ada31a9) (cherry picked from commit f2c4367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
admin updateDynamicConfiguration, the configuration in memory will be changed and the listeners will receive an event.Issue
After calling
admin deleteDynamicConfiguration, the configuration in memory will not change and the listeners will receive nothing.Modifications
When calling
admin deleteDynamicConfigurationDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x