Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [doc] fix the class name of transaction exception. #22687

Merged

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented May 10, 2024

Motivation

image
The full qulified path of the exception in transaction module is wrong, need to fix it.

Modifications

Correct the full qulified path of the exception.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: thetumbled#50

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 10, 2024
@thetumbled
Copy link
Member Author

PTAL, thanks. @dao-jun @lhotari @Technoboy-

@github-actions github-actions bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-not-needed Your PR changes do not impact docs labels May 10, 2024
@thetumbled
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.17%. Comparing base (bbc6224) to head (724746c).
Report is 254 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22687      +/-   ##
============================================
- Coverage     73.57%   73.17%   -0.41%     
+ Complexity    32624     2508   -30116     
============================================
  Files          1877     1888      +11     
  Lines        139502   141233    +1731     
  Branches      15299    15503     +204     
============================================
+ Hits         102638   103344     +706     
- Misses        28908    29905     +997     
- Partials       7956     7984      +28     
Flag Coverage Δ
inttests 27.32% <ø> (+2.73%) ⬆️
systests 24.72% <ø> (+0.40%) ⬆️
unittests 72.17% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 346 files with indirect coverage changes

@lhotari lhotari merged commit b7ec89a into apache:master May 10, 2024
52 of 54 checks passed
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants