-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][offload] Allow to disable the managedLedgerOffloadDeletionLagInMillis #22689
Conversation
@zymap Please add the following content to your PR description and select a checkbox:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
close reopen to trigger the ci checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22689 +/- ##
============================================
- Coverage 73.57% 73.14% -0.43%
- Complexity 32624 32839 +215
============================================
Files 1877 1889 +12
Lines 139502 141393 +1891
Branches 15299 15517 +218
============================================
+ Hits 102638 103423 +785
- Misses 28908 29977 +1069
- Partials 7956 7993 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #xyz
Main Issue: #xyz
PIP: #22688
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: