[fix][offload] Break the fillbuffer loop when met EOF #22722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- ### Motivation When hit an EOF, the write bytes will return -1 then it would make the bytesToCoppy bigger than the buffer to fill. Then we will hit the java.lang.IndexOutOfBoundsException. Break the look when hit the EOF, fill the buffer next time.
zymap
added
type/bug
dao-jun
approved these changes
May 16, 2024
poorbarcode
approved these changes
May 16, 2024
|
Great catch!!! |
shibd
approved these changes
May 16, 2024
lhotari
approved these changes
May 16, 2024
lhotari
reviewed
May 16, 2024
...n/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedInputStreamImpl.java
Show resolved
Hide resolved
shibd
pushed a commit
that referenced
this pull request
May 17, 2024
(cherry picked from commit e35c00e)
shibd
pushed a commit
that referenced
this pull request
May 17, 2024
(cherry picked from commit e35c00e)
shibd
pushed a commit
that referenced
this pull request
May 17, 2024
(cherry picked from commit e35c00e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
When hit an EOF, the write bytes will return -1 then it would make the bytesToCoppy bigger than the buffer to fill. Then we will hit the java.lang.IndexOutOfBoundsException.
Break the look when hit the EOF, fill the buffer next time.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: