Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][test] Restart broker in SimpleProducerConsumerTest if ns deletion times out #22734

Merged
merged 1 commit into from
May 20, 2024
Merged

[improve][test] Restart broker in SimpleProducerConsumerTest if ns deletion times out #22734

merged 1 commit into from
May 20, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented May 17, 2024

Fixes #20553

Motivation

SimpleProducerConsumerTest is flaky. deleteNamespaceWithRetry often times out. It seems that this became more flaky after #22627.

Modifications

  • When the timeout happens, restart the broker.
  • rename the method rest() to cleanupAfterMethod()
  • capture a thread dump to find out if there's a deadlock when the timeout happens

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone May 17, 2024
@lhotari lhotari self-assigned this May 17, 2024
@lhotari lhotari force-pushed the lh-mitigate-flaky-SimpleProducerConsumerTest branch from 5aae50f to 881c73c Compare May 17, 2024 06:55
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 17, 2024
@lhotari
Copy link
Member Author

lhotari commented May 17, 2024

Similar problem in #22736

@lhotari lhotari requested a review from Technoboy- May 17, 2024 12:59
@Technoboy- Technoboy- merged commit 47fd1a3 into apache:master May 20, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@coderzc coderzc Awaiting requested review from coderzc

Assignees

@lhotari lhotari

Labels
doc-not-needed Your PR changes do not impact docs ready-to-test type/flaky-tests
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Flaky-test: SimpleProducerConsumerTest.rest
2 participants
@lhotari @Technoboy-