-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [client] improve the class GetTopicsResult #22766
Merged
poorbarcode
merged 7 commits into
apache:master
from
poorbarcode:fix/regexp_subscription_2
May 30, 2024
Merged
[improve] [client] improve the class GetTopicsResult #22766
poorbarcode
merged 7 commits into
apache:master
from
poorbarcode:fix/regexp_subscription_2
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
The PR fixed a bug or issue reported a bug
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
release/2.11.5
release/3.2.3
release/3.0.6
labels
May 23, 2024
7 tasks
Technoboy-
reviewed
May 23, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
Outdated
Show resolved
Hide resolved
/pulsarbot rerun-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22766 +/- ##
============================================
- Coverage 73.57% 73.22% -0.35%
+ Complexity 32624 32611 -13
============================================
Files 1877 1890 +13
Lines 139502 141522 +2020
Branches 15299 15534 +235
============================================
+ Hits 102638 103633 +995
- Misses 28908 29885 +977
- Partials 7956 8004 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
changed the title
[improve] [client] add an internal API lookupService.getExistsPartitions
[improve] [client] improve the class GetTopicsResult
May 29, 2024
codelipenghui
approved these changes
May 30, 2024
gaoran10
approved these changes
May 30, 2024
lhotari
pushed a commit
that referenced
this pull request
Jun 4, 2024
(cherry picked from commit 87a3339)
poorbarcode
added a commit
that referenced
this pull request
Jun 11, 2024
(cherry picked from commit 87a3339)
poorbarcode
added a commit
that referenced
this pull request
Jun 11, 2024
(cherry picked from commit 87a3339)
poorbarcode
added a commit
that referenced
this pull request
Jul 11, 2024
(cherry picked from commit 87a3339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
cherry-picked/branch-2.11
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.11.5
release/3.0.6
release/3.2.4
release/3.3.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
1.Regarding the API getting topics by regexp pattern, there are two implementations:*
List<String> HttpLookupService.getPartitionedTopicMetadata(...)
CommandGetTopicsOfNamespace BinaryProtoLookupService.getPartitionedTopicMetadata(...)
Pulsar transferred both response types
List<String>
andCommandGetTopicsOfNamespace
to aGetTopicsResult
object. And discarded the partition information when doing transference. For example:topic-1-partition-0
,topic-1-partition-1
.topic-1
.2.The behavior of Patten consumers
createTopicIfDoesNotExist
of Multi Topics Consumer tofalse
.Issue
Modifications
I will submit three PRs to solve the two issues above.
GetTopicsResult
, so we can get the originalpartitions of partitioned topics
createTopicIfDoesNotExist
isfalse
.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x