[fix][broker] Avoid orphan ledgers in BucketDelayedDeliveryTracker

[dao-jun]

Motivation

For BucketDelayedDeliveryTracker, we store the Bucket metadata(position) in Cursor#properties, and remove the property before delete ImmutableBucket.

There is a corner case that it could remove Cursor#properties succeed but delete ImmutableBucket failed.
Since we store the Bucket in Ledgers, if remove Cursor#properties succeed but delete ImmutableBucket failed, the ledger may have a change to be an orphan ledger, not reachable and not usable.

The PR is for the purpose of handle the case, remove Cursor#properties after delete ImmutableBucket, if the Bucket delete succeed but remove Cursor#properties failed we can detect it in the recover phase and remove the properties, to keep the data consistent and avoid orphan ledgers.

Modifications

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM. Good work @dao-jun.

[dao-jun]

@lhotari Many thanks for your review!

merging...

[lhotari]

Needed #23431 for fixing Pulsar CI.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.24%. Comparing base (bbc6224) to head (13be881).
Report is 662 commits behind head on master.

Files with missing lines	Patch %	Lines
...r/delayed/bucket/BucketDelayedDeliveryTracker.java	63.63%	3 Missing and 1 partial ⚠️
...elayed/bucket/BookkeeperBucketSnapshotStorage.java	57.14%	1 Missing and 2 partials ⚠️
...broker/delayed/bucket/BucketNotExistException.java	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22802      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.66%     
- Complexity    32624    34426    +1802     
============================================
  Files          1877     1951      +74     
  Lines        139502   147734    +8232     
  Branches      15299    16403    +1104     
============================================
+ Hits         102638   109682    +7044     
- Misses        28908    29552     +644     
- Partials       7956     8500     +544     

Flag	Coverage Δ
inttests	27.92% <0.00%> (+3.33%)	⬆️
systests	24.37% <0.00%> (+0.05%)	⬆️
unittests	73.58% <68.96%> (+0.73%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...r/delayed/BucketDelayedDeliveryTrackerFactory.java	93.47% <100.00%> (+2.04%)	⬆️
.../pulsar/broker/delayed/bucket/ImmutableBucket.java	85.71% <100.00%> (ø)
...broker/delayed/bucket/BucketNotExistException.java	50.00% <50.00%> (ø)
...elayed/bucket/BookkeeperBucketSnapshotStorage.java	81.25% <57.14%> (-2.49%)	⬇️
...r/delayed/bucket/BucketDelayedDeliveryTracker.java	82.53% <63.63%> (-1.17%)	⬇️

... and 625 files with indirect coverage changes