Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add broker web executor metrics #22816

Merged

Conversation

dragosvictor
Copy link
Contributor

@dragosvictor dragosvictor commented May 31, 2024

PIP-264

Motivation

Adds metrics for the web service executor thread pool, as currently described here. Reference documentation for the new metrics can be found in the respective PR: apache/pulsar-site#907.

Modifications

Expose the respective OpenTelemetry metrics in new class org.apache.pulsar.broker.web.WebExecutorThreadPoolStats#WebExecutorThreadPoolStats.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Extended test org.apache.pulsar.broker.web.WebServiceTest#testWebExecutorMetrics to validate the OpenTelemetry metrics

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics: As describe above
  • Anything that affects deployment

Documentation

Matching PR in forked repository

PR in forked repository: dragosvictor#27

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label May 31, 2024
@dragosvictor dragosvictor marked this pull request as ready for review May 31, 2024 18:22
@lhotari lhotari requested a review from asafm June 3, 2024 09:21
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merlimat merlimat merged commit 4341f0f into apache:master Jun 5, 2024
59 checks passed
@dragosvictor dragosvictor deleted the dmisca-pip-264-web-executor-metrics branch June 7, 2024 16:59
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants