Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [pip] PIP-357: Correct the conf name in load balance module. #22823

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

thetumbled
Copy link
Member

@thetumbled thetumbled commented Jun 3, 2024

Implementation PR: #22824

Motivation

We use loadBalancerBandwithInResourceWeight and loadBalancerBandwithOutResourceWeight to calculate the broker's load in the load balance module. However, the correct conf name should be loadBalancerBandwidthInResourceWeight and loadBalancerBandwidthOutResourceWeight. This PIP is to correct the conf name in the load balance module.

Modifications

Rename loadBalancerBandwithInResourceWeight to loadBalancerBandwidthInResourceWeight and loadBalancerBandwithOutResourceWeight to loadBalancerBandwidthOutResourceWeight in the load balance module.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the PIP label Jun 3, 2024
@thetumbled thetumbled changed the title [improve] [pip] Correct the conf name in load balance module. [improve] [pip] PIP-357: Correct the conf name in load balance module. Jun 3, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 3, 2024
@heesung-sn
Copy link
Contributor

This is very unfortunate.

Can we additionally parse those old ones in the Pulsar code and apply them instead of the new configs, if the new configs are 1.0 (default) but the old ones are not 1.0(non default) -- this means most likely the user still relies on the old one?

@Demogorgon314
Copy link
Member

We can apply the following strategy to address the compatibility issue:

  • If which configuration is not the default, then that one is used.
  • If both the new and the old are configured, use the new one.

@thetumbled
Copy link
Member Author

thetumbled commented Jun 4, 2024

We can apply the following strategy to address the compatibility issue:

  • If which configuration is not the default, then that one is used.
  • If both the new and the old are configured, use the new one.

Agree, i have updated the doc, PTAL, thanks. @heesung-sn @Demogorgon314 @BewareMyPower @codelipenghui

@heesung-sn
Copy link
Contributor

LGTM

@Technoboy-
Copy link
Contributor

The vote passed. merging.

@Technoboy- Technoboy- added this to the 3.4.0 milestone Jun 6, 2024
@Technoboy- Technoboy- merged commit fb80007 into apache:master Jun 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants