-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] [pip] PIP-357: Correct the conf name in load balance module. #22823
Conversation
This is very unfortunate. Can we additionally parse those old ones in the Pulsar code and apply them instead of the new configs, if the new configs are 1.0 (default) but the old ones are not 1.0(non default) -- this means most likely the user still relies on the old one? |
We can apply the following strategy to address the compatibility issue:
|
Agree, i have updated the doc, PTAL, thanks. @heesung-sn @Demogorgon314 @BewareMyPower @codelipenghui |
LGTM |
The vote passed. merging. |
Implementation PR: #22824
Motivation
We use
loadBalancerBandwithInResourceWeight
andloadBalancerBandwithOutResourceWeight
to calculate the broker's load in the load balance module. However, the correct conf name should beloadBalancerBandwidthInResourceWeight
andloadBalancerBandwidthOutResourceWeight
. This PIP is to correct the conf name in the load balance module.Modifications
Rename
loadBalancerBandwithInResourceWeight
toloadBalancerBandwidthInResourceWeight
andloadBalancerBandwithOutResourceWeight
toloadBalancerBandwidthOutResourceWeight
in the load balance module.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: