[improve] Use Google re2/j library for user provided regexes

[merlimat]

Motivation

Google RE2/J library provide regex library that has worst case linear time processing of pattern, as opposed to standard JDK regexes which could have recursive processing. It's better to avoid these corner cases by just swapping the Pattern class implementation. It's a drop-in replacement for the basic methods we're using, and RE2/J is already a transitive dependency.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (bbc6224) to head (797703c).
Report is 340 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22829      +/-   ##
============================================
- Coverage     73.57%   73.26%   -0.32%     
- Complexity    32624    32955     +331     
============================================
  Files          1877     1888      +11     
  Lines        139502   141764    +2262     
  Branches      15299    15559     +260     
============================================
+ Hits         102638   103858    +1220     
- Misses        28908    29880     +972     
- Partials       7956     8026      +70     

Flag	Coverage Δ
inttests	27.45% <0.00%> (+2.87%)	⬆️
systests	24.90% <100.00%> (+0.57%)	⬆️
unittests	72.27% <100.00%> (-0.58%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...va/org/apache/pulsar/broker/service/ServerCnx.java	72.00% <ø> (-0.15%)	⬇️
...apache/pulsar/broker/service/TopicListService.java	67.20% <ø> (ø)
...ar/client/impl/PatternMultiTopicsConsumerImpl.java	83.45% <ø> (ø)
...rg/apache/pulsar/client/impl/PulsarClientImpl.java	73.85% <100.00%> (-0.45%)	⬇️
...rg/apache/pulsar/client/impl/TopicListWatcher.java	67.14% <ø> (-0.72%)	⬇️
...ava-templates/org/apache/pulsar/PulsarVersion.java	78.12% <ø> (ø)
...ava/org/apache/pulsar/common/topics/TopicList.java	89.65% <ø> (ø)

... and 378 files with indirect coverage changes

[lhotari]

@merlimat which branches do we target with this change? do you think that it's safe to cherry-pick this to maintenance branches?

[merlimat]

@merlimat which branches do we target with this change? do you think that it's safe to cherry-pick this to maintenance branches?

I think it should be fairly safe, given all "normal" regexes should behave in same way as before. At the same time, I don't think there's urgency to patch in stable branches, so I'd say to skip it unless it's needed later.