[fix] [broker] response not-found error if topic does not exist when calling getPartitionedTopicMetadata #22838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
ready-to-test
and removed
doc-not-needed
|
/pulsarbot rerun-failure-checks |
lhotari
previously requested changes
Jun 4, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Jun 4, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
Outdated
Show resolved
Hide resolved
…calling getPartitionedTopicMetadata
poorbarcode
force-pushed
the
pip_344/part_4
branch
from
b7ce67c
to
3e061cc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22838 +/- ##
============================================
- Coverage 73.57% 73.26% -0.31%
- Complexity 32624 33033 +409
============================================
Files 1877 1892 +15
Lines 139502 142015 +2513
Branches 15299 15576 +277
============================================
+ Hits 102638 104047 +1409
- Misses 28908 29949 +1041
- Partials 7956 8019 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/TopicExistsInfo.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Jun 11, 2024
Technoboy-
reviewed
Jun 11, 2024
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java
Show resolved
Hide resolved
Technoboy-
approved these changes
Jun 11, 2024
|
@lhotari Could you take a look at your convenience |
poorbarcode
dismissed
lhotari’s stale review
The review has been no response for a long time
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 24, 2024
…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 25, 2024
…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)
shibd
added
the
release/important-notice
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…calling getPartitionedTopicMetadata (apache#22838) (cherry picked from commit 9aed736) (cherry picked from commit 1d2959b)
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
Section Instead of returning a 0 partitioned metadata, respond to a not found error when calling pulsarClient.getPartitionsForTopic(String) if the topic does not exist.
Main PIP: PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x