[fix] [test] fix testGetMetrics in ExtensibleLoadManagerImplTest. #22864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL, thanks. @heesung-sn @Demogorgon314 |
Demogorgon314
approved these changes
Jun 7, 2024
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22864 +/- ##
============================================
- Coverage 73.57% 73.26% -0.31%
+ Complexity 32624 2511 -30113
============================================
Files 1877 1889 +12
Lines 139502 141830 +2328
Branches 15299 15563 +264
============================================
+ Hits 102638 103916 +1278
- Misses 28908 29887 +979
- Partials 7956 8027 +71
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I'm wondering why this failed test was not detected before? |
This is a flaky test, which can be ignored when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22871
Motivation
As #22820 set the default value of
LoadBalancerMemoryResourceWeightto 0, some behavior changes resulting into the failure oforg.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImplTest#testGetMetrics.Modifications
Set the value of
LoadBalancerMemoryResourceWeightto 1 to pass the test.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: