[fix][misc] Disable JFR based telemetry collection since it's not used #22869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and consumes resources
|
@dragosvictor Please review. It looks like we didn't properly disable JFR metrics in #22616 or the 1.38.0 upgrade enabled more JFR metrics by default. |
merlimat
approved these changes
Jun 7, 2024
|
LGTM. |
merlimat
pushed a commit
that referenced
this pull request
Jun 7, 2024
dragosvictor
reviewed
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
JFR based telemetry collection consumes resources. We don't currently use the metrics for anything.
This happens in MultiBrokerLeaderElectionTest which starts 10 embedded brokers in the test. The test JVM often fails with OOM.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete