[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded #22892

lhotari · 2024-06-11T17:19:11Z

Fixes #22601
Fixes #21892
Fixes #19460

Motivation

Netty 4.1.111.Final contains important fixes:

Optimize wrap buffer cumulation in SslHandler and don't mutate input buffers netty/netty#14086
Duplicate of slice should have the same capacity as the original slice so that it's not writable netty/netty#14093

These address Broker stability when TLS with Bookkeeper V2 protocol is used between Broker and Bookies.
This will also allow removing the extra buffer copies that have been in place in Pulsar broker and Pulsar client when TLS is enabled.

pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/ByteBufPair.java

Lines 138 to 157 in 266243c

    
           public static class CopyingEncoder extends ChannelOutboundHandlerAdapter { 
        
               @Override 
        
               public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception { 
        
                   if (msg instanceof ByteBufPair) { 
        
                       ByteBufPair b = (ByteBufPair) msg; 
        
                       // Some handlers in the pipeline will modify the bytebufs passed in to them (i.e. SslHandler). 
        
                       // For these handlers, we need to pass a copy of the buffers as the source buffers may be cached 
        
                       // for multiple requests. 
        
                       try { 
        
                           ctx.write(b.getFirst().copy(), ctx.voidPromise()); 
        
                           ctx.write(b.getSecond().copy(), promise); 
        
                       } finally { 
        
                           ReferenceCountUtil.safeRelease(b); 
        
                       } 
        
                   } else { 
        
                       ctx.write(msg, promise); 
        
                   } 
        
               } 
        
           }

This will be removed in a separate PR.

Modifications

Upgrade Netty to 4.1.111.Final version

Documentation

doc
doc-required
doc-not-needed
doc-complete

lhotari · 2024-06-12T07:09:51Z

etcd tests break with Netty 4.1.111.Final. There's some compatibility issue.
I also tried upgrading jetcd to 0.8.2 and grpc to 1.64.0, but that didn't help.

lhotari · 2024-06-12T07:33:50Z

It seems that grpc-netty dependency will have to be excluded and replaced by grpc-netty-shaded since grpc is compatible only with specific Netty versions.

lhotari · 2024-06-12T07:53:10Z

Unfortunately jetcd-core isn't compatible with grpc-netty-shaded. There are conflicts with io.grpc.netty.GrpcSslContexts/io.grpc.netty.shaded.io.grpc.netty.GrpcSslContexts and io.netty.handler.ssl.SslContext/io.grpc.netty.shaded.io.netty.handler.ssl.SslContext classes. The only solution seems to be to do custom shading for jetcd-core and jetcd-test.

lhotari · 2024-06-12T13:06:56Z

I found a reasonable solution by shading jetcd-core in a way where vertx is relocated and included, but grpc is switched to use grpc-netty-shaded instead of grpc-netty. stream-storage-java-client supports switching to use grpc-netty-shaded without making changes to the module.
This resolves the issue with grpc-netty and Netty 4.1.111.Final.

…-netty-shaded (#22892)

merlimat · 2024-06-12T22:29:26Z

@lhotari There are quite a few merge conflict everywhere (except for 3.3). I'm not sure how difficult it would be to backport.

lhotari · 2024-06-13T04:57:20Z

@lhotari There are quite a few merge conflict everywhere (except for 3.3). I'm not sure how difficult it would be to backport.

I'll handle the backporting. I think it's doable.

…-netty-shaded (#22892) (cherry picked from commit 75d7e55)

…-netty-shaded (#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b) # Conflicts: # distribution/server/pom.xml

…-netty-shaded (#22892) (cherry picked from commit 75d7e55)

- version in jetcd-core-shaded/pom.xml needs to match project version

…use grpc-netty-shaded (apache#22892)" This reverts commit 75d7e55.

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

inetfuture · 2024-09-11T16:15:47Z

@lhotari Hi, I'm trying to deploy Pulsar v3.3.1 on K8s with etcd as metastore using the official Docker image, got an exception when executing bin/bookkeeper shell whatisinstanceid in pulsar-bookie-init job.

2024-09-11T16:10:48,297+0000 [main] INFO  org.apache.bookkeeper.meta.MetadataDrivers - BookKeeper metadata driver manager initialized
2024-09-11T16:10:48,408+0000 [main] ERROR org.apache.bookkeeper.bookie.BookieShell - Got an exception
java.lang.NoClassDefFoundError: io/grpc/netty/shaded/io/grpc/netty/shaded/io/netty/handler/logging/ByteBufFormat
	at org.apache.pulsar.jetcd.shaded.io.vertx.core.net.NetworkOptions.<clinit>(NetworkOptions.java:62) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at org.apache.pulsar.jetcd.shaded.io.vertx.core.VertxOptions.<init>(VertxOptions.java:143) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.vertx(ClientConnectionManager.java:223) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.defaultChannelBuilder(ClientConnectionManager.java:158) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.defaultChannelBuilder(ClientConnectionManager.java:149) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.getChannel(ClientConnectionManager.java:70) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.newStub(ClientConnectionManager.java:102) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.KVImpl.<init>(KVImpl.java:51) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientImpl.lambda$new$0(ClientImpl.java:48) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.support.MemorizingClientSupplier.get(MemorizingClientSupplier.java:37) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientImpl.getKVClient(ClientImpl.java:65) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.EtcdMetadataStore.<init>(EtcdMetadataStore.java:111) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.EtcdMetadataStoreProvider.create(EtcdMetadataStore.java:515) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.MetadataStoreFactoryImpl.newInstance(MetadataStoreFactoryImpl.java:63) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.MetadataStoreFactoryImpl.createExtended(MetadataStoreFactoryImpl.java:50) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.api.extended.MetadataStoreExtended.create(MetadataStoreExtended.java:42) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.AbstractMetadataDriver.createMetadataStore(AbstractMetadataDriver.java:117) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.AbstractMetadataDriver.initialize(AbstractMetadataDriver.java:59) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.PulsarMetadataBookieDriver.initialize(PulsarMetadataBookieDriver.java:45) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithMetadataBookieDriver(MetadataDrivers.java:356) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithRegistrationManager(MetadataDrivers.java:383) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.tools.cli.commands.bookies.InstanceIdCommand.apply(InstanceIdCommand.java:49) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell$WhatIsInstanceId.runCmd(BookieShell.java:1685) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell$MyCommand.runCmd(BookieShell.java:254) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell.run(BookieShell.java:2674) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell.main(BookieShell.java:2771) [org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
Caused by: java.lang.ClassNotFoundException: io.grpc.netty.shaded.io.grpc.netty.shaded.io.netty.handler.logging.ByteBufFormat
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source) ~[?:?]
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source) ~[?:?]
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source) ~[?:?]
	... 26 more

It seems to me that this PR is related, any idea how to fix this? Thanks.

inetfuture · 2024-09-12T10:09:27Z

I tried 3.2.4, 3.0.6 and 3.0.5, only 3.0.5 works, and I noticed this commit isnt't on 3.3.1, so I guess I'll wait and try 4.0 when it's released.

lhotari · 2024-09-24T11:50:00Z

@lhotari Hi, I'm trying to deploy Pulsar v3.3.1 on K8s with etcd as metastore using the official Docker image, got an exception when executing bin/bookkeeper shell whatisinstanceid in pulsar-bookie-init job.

2024-09-11T16:10:48,297+0000 [main] INFO  org.apache.bookkeeper.meta.MetadataDrivers - BookKeeper metadata driver manager initialized
2024-09-11T16:10:48,408+0000 [main] ERROR org.apache.bookkeeper.bookie.BookieShell - Got an exception
java.lang.NoClassDefFoundError: io/grpc/netty/shaded/io/grpc/netty/shaded/io/netty/handler/logging/ByteBufFormat
	at org.apache.pulsar.jetcd.shaded.io.vertx.core.net.NetworkOptions.<clinit>(NetworkOptions.java:62) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at org.apache.pulsar.jetcd.shaded.io.vertx.core.VertxOptions.<init>(VertxOptions.java:143) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.vertx(ClientConnectionManager.java:223) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.defaultChannelBuilder(ClientConnectionManager.java:158) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.defaultChannelBuilder(ClientConnectionManager.java:149) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.getChannel(ClientConnectionManager.java:70) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientConnectionManager.newStub(ClientConnectionManager.java:102) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.KVImpl.<init>(KVImpl.java:51) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientImpl.lambda$new$0(ClientImpl.java:48) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.support.MemorizingClientSupplier.get(MemorizingClientSupplier.java:37) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at io.etcd.jetcd.impl.ClientImpl.getKVClient(ClientImpl.java:65) ~[org.apache.pulsar-jetcd-core-shaded-3.3.1-shaded.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.EtcdMetadataStore.<init>(EtcdMetadataStore.java:111) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.EtcdMetadataStoreProvider.create(EtcdMetadataStore.java:515) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.MetadataStoreFactoryImpl.newInstance(MetadataStoreFactoryImpl.java:63) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.impl.MetadataStoreFactoryImpl.createExtended(MetadataStoreFactoryImpl.java:50) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.api.extended.MetadataStoreExtended.create(MetadataStoreExtended.java:42) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.AbstractMetadataDriver.createMetadataStore(AbstractMetadataDriver.java:117) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.AbstractMetadataDriver.initialize(AbstractMetadataDriver.java:59) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.pulsar.metadata.bookkeeper.PulsarMetadataBookieDriver.initialize(PulsarMetadataBookieDriver.java:45) ~[org.apache.pulsar-pulsar-metadata-3.3.1.jar:3.3.1]
	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithMetadataBookieDriver(MetadataDrivers.java:356) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.meta.MetadataDrivers.runFunctionWithRegistrationManager(MetadataDrivers.java:383) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.tools.cli.commands.bookies.InstanceIdCommand.apply(InstanceIdCommand.java:49) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell$WhatIsInstanceId.runCmd(BookieShell.java:1685) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell$MyCommand.runCmd(BookieShell.java:254) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell.run(BookieShell.java:2674) ~[org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
	at org.apache.bookkeeper.bookie.BookieShell.main(BookieShell.java:2771) [org.apache.bookkeeper-bookkeeper-server-4.17.1.jar:4.17.1]
Caused by: java.lang.ClassNotFoundException: io.grpc.netty.shaded.io.grpc.netty.shaded.io.netty.handler.logging.ByteBufFormat
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source) ~[?:?]
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source) ~[?:?]
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source) ~[?:?]
	... 26 more

It seems to me that this PR is related, any idea how to fix this? Thanks.

@inetfuture Please report a separate GH issue with steps to reproduce. That will be helpful in addressing this problem.

lhotari added area/dependency Pull requests that update a dependency file ready-to-test release/3.1.5 release/3.3.1 release/3.0.6 release/3.2.4 labels Jun 11, 2024

lhotari added this to the 3.4.0 milestone Jun 11, 2024

lhotari requested review from merlimat, hangc0276, Technoboy-, codelipenghui and poorbarcode June 11, 2024 17:19

lhotari self-assigned this Jun 11, 2024

github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 11, 2024

lhotari mentioned this pull request Jun 11, 2024

[fix][broker] Fix data corruption issues when TLS is enabled and optimize TLS between Pulsar client and brokers #22810

Closed

4 tasks

Technoboy- approved these changes Jun 12, 2024

View reviewed changes

lhotari mentioned this pull request Jun 12, 2024

Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded apache/bookkeeper#4426

Merged

dao-jun approved these changes Jun 12, 2024

View reviewed changes

lhotari added 3 commits June 12, 2024 16:03

[improve][misc] Upgrade to Netty 4.1.111.Final

d6683ca

Add jetcd-core-shaded module which uses grpc-netty-shaded

b11f402

Use grpc-netty-shaded for stream-storage-java-client

faebbf2

lhotari force-pushed the lh-netty-4.1.111 branch from 53c8760 to faebbf2 Compare June 12, 2024 13:03

lhotari added 4 commits June 12, 2024 18:08

Add dependency-reduced-pom.xml into the shaded jar

b293860

Add transient jetcd dependencies to jetcd-core-shaded

f1431db

Add exclusions for jetcd-core-shaded

9773857

Define exclusions in dependencyManagement for jetcd-core-shaded

822c87c

merlimat pushed a commit that referenced this pull request Jun 12, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

8784711

…-netty-shaded (#22892)

merlimat added the cherry-picked/branch-3.3 label Jun 12, 2024

lhotari added a commit that referenced this pull request Jun 13, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

a982d7b

…-netty-shaded (#22892) (cherry picked from commit 75d7e55)

lhotari added the cherry-picked/branch-3.0 label Jun 13, 2024

lhotari added release/3.1.4 cherry-picked/branch-3.1 labels Jun 13, 2024

lhotari added a commit that referenced this pull request Jun 13, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

cdda561

…-netty-shaded (#22892) (cherry picked from commit 75d7e55)

lhotari added the cherry-picked/branch-3.2 label Jun 13, 2024

lhotari added a commit that referenced this pull request Jun 13, 2024

[fix] Fix cherry-pick for #22892

e75f6ba

- version in jetcd-core-shaded/pom.xml needs to match project version

lhotari mentioned this pull request Jun 14, 2024

[Bug] Ledger can not recover with Digest Mismatch Error #22906

Open

3 tasks

lhotari added a commit to lhotari/pulsar that referenced this pull request Jun 14, 2024

Revert "[improve][misc] Upgrade to Netty 4.1.111.Final and switch to …

3396138

…use grpc-netty-shaded (apache#22892)" This reverts commit 75d7e55.

This was referenced Jun 19, 2024

[improve][misc][WIP] Detect "double release" and "use after release" bugs with recycled objects #22110

Draft

[fix][ci] Fix jacoco code coverage report aggregation #22964

Merged

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 25, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

7ca018a

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

ad06559

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

a150c1e

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

27146ce

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

692258c

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc…

8ced787

…-netty-shaded (apache#22892) (cherry picked from commit 75d7e55) (cherry picked from commit a982d7b)

martin31821 mentioned this pull request Aug 13, 2024

[Bug] [Regression] etcd mTLS doesn't work on 3.3.1 #23160

Open

3 tasks

nodece mentioned this pull request Sep 24, 2024

[fix][build] Remove io.grpc.netty relocation #23342

Closed

4 tasks

suninuni mentioned this pull request Oct 24, 2024

[Bug] NoClassDefFoundError: io/grpc/netty/shaded/io/grpc/netty/shaded/io/netty/handler/logging/ByteBufFormat #23513

Closed

3 tasks

This was referenced Nov 15, 2024

[fix][misc] Unable to connect an etcd metastore with recent releases due to jetc-core sharding problem #23604

Merged

Fix potential jetcd core shading problem Shawyeok/bookkeeper#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded #22892

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded #22892

lhotari commented Jun 11, 2024 •

edited

Loading

lhotari commented Jun 12, 2024

lhotari commented Jun 12, 2024 •

edited

Loading

lhotari commented Jun 12, 2024

lhotari commented Jun 12, 2024

merlimat commented Jun 12, 2024

lhotari commented Jun 13, 2024

inetfuture commented Sep 11, 2024

inetfuture commented Sep 12, 2024

lhotari commented Sep 24, 2024

	public static class CopyingEncoder extends ChannelOutboundHandlerAdapter {
	@Override
	public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise) throws Exception {
	if (msg instanceof ByteBufPair) {
	ByteBufPair b = (ByteBufPair) msg;

	// Some handlers in the pipeline will modify the bytebufs passed in to them (i.e. SslHandler).
	// For these handlers, we need to pass a copy of the buffers as the source buffers may be cached
	// for multiple requests.
	try {
	ctx.write(b.getFirst().copy(), ctx.voidPromise());
	ctx.write(b.getSecond().copy(), promise);
	} finally {
	ReferenceCountUtil.safeRelease(b);
	}
	} else {
	ctx.write(msg, promise);
	}
	}
	}

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded #22892

[improve][misc] Upgrade to Netty 4.1.111.Final and switch to use grpc-netty-shaded #22892

Conversation

lhotari commented Jun 11, 2024 • edited Loading

Motivation

Modifications

Documentation

lhotari commented Jun 12, 2024

lhotari commented Jun 12, 2024 • edited Loading

lhotari commented Jun 12, 2024

lhotari commented Jun 12, 2024

merlimat commented Jun 12, 2024

lhotari commented Jun 13, 2024

inetfuture commented Sep 11, 2024

inetfuture commented Sep 12, 2024

lhotari commented Sep 24, 2024

lhotari commented Jun 11, 2024 •

edited

Loading

lhotari commented Jun 12, 2024 •

edited

Loading