Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][misc] Replace rename-netty-native-libs.sh script with renaming with maven-shade-plugin #22957

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[improve][misc] Replace rename-netty-native-libs.sh script with renaming with maven-shade-plugin #22957

merged 1 commit into from
Jun 24, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 24, 2024 •
edited
Loading

Motivation

The current rename-netty-native-libs.sh script is error prone for renaming the native Netty libraries in the shaded jar file.

Modifications

Use maven-shade-plugin for renaming

<!-- Rename Netty native libraries to include the shaded prefix -->
<relocation>
  <pattern>(META-INF/native/(lib)?)(netty.+\.(so|jnilib|dll))$</pattern>
  <shadedPattern>$1org_apache_pulsar_shade_$3</shadedPattern>
  <rawString>true</rawString>
</relocation>

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.4.0 milestone Jun 24, 2024
@lhotari lhotari self-assigned this Jun 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 24, 2024
@lhotari lhotari force-pushed the lh-replace-rename-netty-native-libs branch from fc4ced8 to 8d6a383 Compare June 24, 2024 10:35
nodece
nodece approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Copy link
Member

nodece commented Jun 24, 2024

Changed:

  liborg_apache_pulsar_shade_netty_resolver_dns_native_macos_aarch_64.jnilib
  liborg_apache_pulsar_shade_netty_resolver_dns_native_macos_x86_64.jnilib
  liborg_apache_pulsar_shade_netty_tcnative_linux_aarch_64.so
  liborg_apache_pulsar_shade_netty_tcnative_linux_x86_64.so
  liborg_apache_pulsar_shade_netty_tcnative_osx_aarch_64.jnilib
  liborg_apache_pulsar_shade_netty_tcnative_osx_x86_64.jnilib
  liborg_apache_pulsar_shade_netty_transport_native_epoll_aarch_64.so
  liborg_apache_pulsar_shade_netty_transport_native_epoll_x86_64.so
  liborg_apache_pulsar_shade_netty_transport_native_io_uring_aarch_64.so
  liborg_apache_pulsar_shade_netty_transport_native_io_uring_x86_64.so
  org_apache_pulsar_shade_netty_tcnative_windows_x86_64.dll

@lhotari lhotari closed this Jun 24, 2024
@lhotari lhotari reopened this Jun 24, 2024
@lhotari lhotari merged commit f728b2e into apache:master Jun 24, 2024
91 of 103 checks passed
lhotari added a commit that referenced this pull request Jun 24, 2024
@lhotari
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
df070b6 
…ing with maven-shade-plugin (#22957)

(cherry picked from commit f728b2e)
lhotari added a commit that referenced this pull request Jun 24, 2024
@lhotari
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
68d92fe 
…ing with maven-shade-plugin (#22957)

(cherry picked from commit f728b2e)
lhotari added a commit that referenced this pull request Jun 24, 2024
@lhotari
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
9466eb3 
…ing with maven-shade-plugin (#22957)

(cherry picked from commit f728b2e)
lhotari added a commit that referenced this pull request Jun 24, 2024
@lhotari
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
09fd1ad 
…ing with maven-shade-plugin (#22957)

(cherry picked from commit f728b2e)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
@lhotari @nikhil-ctds
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
651ec29 
…ing with maven-shade-plugin (apache#22957)

(cherry picked from commit f728b2e)
(cherry picked from commit 68d92fe)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
@lhotari @nikhil-ctds
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
027716c 
…ing with maven-shade-plugin (apache#22957)

(cherry picked from commit f728b2e)
(cherry picked from commit 68d92fe)
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Jun 27, 2024
@lhotari @nikhil-ctds
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
b963216 
…ing with maven-shade-plugin (apache#22957)

(cherry picked from commit f728b2e)
(cherry picked from commit df070b6)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
@lhotari @srinath-ctds
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
0f4c208 
…ing with maven-shade-plugin (apache#22957)

(cherry picked from commit f728b2e)
(cherry picked from commit 68d92fe)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Jul 1, 2024
@lhotari @srinath-ctds
[improve][misc] Replace rename-netty-native-libs.sh script with renam…
2331017 
…ing with maven-shade-plugin (apache#22957)

(cherry picked from commit f728b2e)
(cherry picked from commit df070b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodece nodece nodece approved these changes

@merlimat merlimat Awaiting requested review from merlimat

@Technoboy- Technoboy- Awaiting requested review from Technoboy-

@eolivelli eolivelli Awaiting requested review from eolivelli

@dao-jun dao-jun Awaiting requested review from dao-jun

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

@cbornet cbornet Awaiting requested review from cbornet

@crossoverJie crossoverJie Awaiting requested review from crossoverJie

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@shoothzj shoothzj Awaiting requested review from shoothzj

Assignees

@lhotari lhotari

Labels
area/build cherry-picked/branch-3.0 cherry-picked/branch-3.1 cherry-picked/branch-3.2 cherry-picked/branch-3.3 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.6 release/3.1.4 release/3.2.4 release/3.3.1
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lhotari @nodece