[fix][broker] Fix updatePartitionedTopic when replication at ns level and topic policy is set #22971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
3 tasks
… and topic policy is set
lhotari
force-pushed
the
lh-fix-updatePartitionedTopic-when-replication-at-ns-level-and-topic-policy-is-set
branch
from
4b2feeb
to
e744566
Compare
poorbarcode
approved these changes
Jun 25, 2024
nodece
approved these changes
Jun 25, 2024
|
Thanks @lhotari for taking this up. Can this be cherry-picked in branch 3.0? |
@iosdev747 Yes, this PR has been cherry-picked to branch-3.0. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
… and topic policy is set (apache#22971) (cherry picked from commit 1c44fbb) (cherry picked from commit d93e896)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
… and topic policy is set (apache#22971) (cherry picked from commit 1c44fbb) (cherry picked from commit d93e896)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22967
Motivation
There's a bug in updatePartitionedTopic when replication is defined at namespace level and there's a topic policy available for the topic that is updated. This seems to be a gap in #22769.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete