Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][broker] PIP-264: Add OpenTelemetry managed cursor metrics #23000

Merged

Conversation

dragosvictor
Copy link
Contributor

PIP-264

Motivation

Adds Managed Cursor metrics, as currently described here, to the OpenTelemetry pipeline.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

This change modified tests and can be verified as follows:

  • Updated tests ManagedCursorMetricsTest#testManagedCursorMetrics and ManagedCursorMetricsTest#testCursorReadWriteMetrics to cover the OpenTelemetry metrics

Does this pull request potentially affect one of the following parts:

Documentation

Matching PR in forked repository

PR in forked repository: dragosvictor#34

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Jul 3, 2024
@dragosvictor dragosvictor changed the title Dmisca pip 264 managed cursor metrics [feat][broker] PIP-264: Add OpenTelemetry managed cursor metrics Jul 3, 2024
@dragosvictor dragosvictor marked this pull request as ready for review July 3, 2024 20:36
@dao-jun dao-jun added this to the 3.4.0 milestone Jul 4, 2024
@merlimat merlimat merged commit 8351c07 into apache:master Jul 5, 2024
55 of 57 checks passed
@dragosvictor dragosvictor deleted the dmisca-pip-264-managed-cursor-metrics branch July 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics area/ML doc-required Your PR changes impact docs and you will update later. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants