-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] don't do load shedding when metadata service not available #23040
Merged
congbobo184
merged 5 commits into
apache:master
from
congbobo184:improve/loadbalance/metadata_service_not_available_dont_do_load_shedding
Jul 22, 2024
Merged
[improve][broker] don't do load shedding when metadata service not available #23040
congbobo184
merged 5 commits into
apache:master
from
congbobo184:improve/loadbalance/metadata_service_not_available_dont_do_load_shedding
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
poorbarcode,
codelipenghui,
gaoran10,
liangyepianzhou,
lhotari and
eolivelli
July 16, 2024 12:07
congbobo184
changed the title
[improve][broker] don't do load shedding when metadata service not av…
[improve][broker] don't do load shedding when metadata service not available
Jul 16, 2024
poorbarcode
approved these changes
Jul 17, 2024
poorbarcode
reviewed
Jul 17, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LoadSheddingTask.java
Show resolved
Hide resolved
…/metadata_service_not_available_dont_do_load_shedding
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23040 +/- ##
============================================
- Coverage 73.57% 73.48% -0.10%
- Complexity 32624 33196 +572
============================================
Files 1877 1915 +38
Lines 139502 143948 +4446
Branches 15299 15727 +428
============================================
+ Hits 102638 105773 +3135
- Misses 28908 30071 +1163
- Partials 7956 8104 +148
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dao-jun
approved these changes
Jul 19, 2024
congbobo184
force-pushed
the
improve/loadbalance/metadata_service_not_available_dont_do_load_shedding
branch
from
July 22, 2024 03:37
78b0a99
to
243aa81
Compare
…/metadata_service_not_available_dont_do_load_shedding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
don't do load shedding when metadata service not available.
if unload bundle when metadata service not available, these topics which in this bundle can't recover the current ledger and send read again
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: