Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-367: Propose a Contributor Repository for Pulsar #23061

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Jul 22, 2024

Motivation

See proposal for detail.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the PIP label Jul 22, 2024
@liangyepianzhou liangyepianzhou self-assigned this Jul 22, 2024
@github-actions github-actions bot added doc-label-missing doc-required Your PR changes impact docs and you will update later. and removed doc-label-missing labels Jul 22, 2024
@liangyepianzhou liangyepianzhou changed the title [improve][pip] Add new contrib repo for Pulsar [improve][pip] Propose a Contributor Repository for Pulsar Jul 22, 2024
@apache apache deleted a comment from github-actions bot Jul 22, 2024
@StevenLuMT
Copy link
Member

Our XHS team(@liangyepianzhou @AuroraTwinkle @StevenLuMT @cai152) will submit a few to pulsar-java-contrib as a primer to let everyone know the role of this library

@dave2wave
Copy link
Member

Using a website building repository template as the basis for this effort is confusing.

@liangyepianzhou
Copy link
Contributor Author

@dave2wave @eolivelli Enrico and I had some discussions in emails. These discussions led me to refine my ideas and create a prototype of the project in the new repository. [0] This project prototype will show what we want to do better than the documentation.

[0] - https://github.com/StevenLuMT/pulsar-java-contrib

@dave2wave dave2wave changed the title [improve][pip] Propose a Contributor Repository for Pulsar [improve][pip] PIP-367: Propose a Contributor Repository for Pulsar Aug 2, 2024
@liangyepianzhou
Copy link
Contributor Author

As the initial contributors, we have drafted a contribution plan. We will gradually improve this contributor repository in accordance with this plan.

StevenLuMT/pulsar-java-contrib#7

@liangyepianzhou
Copy link
Contributor Author

@lhotari How should this proposal be handled in the future? Will it be merged with other voted proposals, or will it be closed?

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging since the PIP has been approved in https://lists.apache.org/thread/td0j8l1c3l93nny0m5smnsdmb91j1n2y .

@lhotari lhotari merged commit 9f7b487 into apache:master Oct 14, 2024
20 checks passed
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
@liangyepianzhou liangyepianzhou deleted the contrib branch October 28, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants