[fix][client] Fix for multiple hit at the interceptor for MultiTopicConsumer #23080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 30, 2024 10:23
…tiTopicConsumer" This reverts commit 3305c0a.
coderzc
requested changes
Aug 8, 2024
| @@ -1113,7 +1114,7 @@ private ConsumerImpl<T> createInternalConsumer(ConsumerConfigurationData<T> conf | |||
| return ConsumerImpl.newConsumerImpl(client, partitionName, | |||
| configurationData, client.externalExecutorProvider(), | |||
| partitionIndex, true, listener != null, subFuture, | |||
| startMessageId, schema, interceptors, | |||
| startMessageId, schema, null, | |||
There was a problem hiding this comment.
we can't remove interceptors from internal consumer directly this will make other interceptor methods not work
| @@ -379,6 +379,7 @@ protected Message<T> internalReceive(long timeout, TimeUnit unit) throws PulsarC | |||
| long callTime = System.nanoTime(); | |||
| try { | |||
| message = incomingMessages.poll(timeout, unit); | |||
| message = beforeConsume(message); | |||
There was a problem hiding this comment.
Also need to call beforeConsume on internalReceiveAsync、internalReceive(long timeout, TimeUnit unit) 、messageReceived
|
I open another PR(#23141) to fix this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.