Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker]: fix irregular method name #23108

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

AuroraTwinkle
Copy link
Contributor

@AuroraTwinkle AuroraTwinkle commented Jul 31, 2024

Fixes: fix irregular method name

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: AuroraTwinkle#5

@AuroraTwinkle AuroraTwinkle changed the title fix[typo]: fix irregular method name fix[broker]: fix irregular method name Jul 31, 2024
@AuroraTwinkle AuroraTwinkle changed the title fix[broker]: fix irregular method name [fix][broker]: fix irregular method name Jul 31, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (bbc6224) to head (c6c5681).
Report is 485 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23108      +/-   ##
============================================
- Coverage     73.57%   73.41%   -0.16%     
- Complexity    32624    33208     +584     
============================================
  Files          1877     1919      +42     
  Lines        139502   144106    +4604     
  Branches      15299    15747     +448     
============================================
+ Hits         102638   105795    +3157     
- Misses        28908    30180    +1272     
- Partials       7956     8131     +175     
Flag Coverage Δ
inttests 27.77% <ø> (+3.19%) ⬆️
systests 24.75% <ø> (+0.42%) ⬆️
unittests 72.48% <ø> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/java/org/apache/pulsar/broker/PulsarService.java 82.99% <ø> (+0.62%) ⬆️

... and 521 files with indirect coverage changes

@liangyepianzhou liangyepianzhou merged commit 92bcd07 into apache:master Jul 31, 2024
51 checks passed
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
Co-authored-by: duanlinlin <duanlinllin@xiaohongshu.com>

Fixes: fix irregular method name
@lhotari lhotari added this to the 4.0.0 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants