[improve][fn] Add support for overriding additionalJavaRuntimeArguments with PF_additionalJavaRuntimeArguments env #23130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imeArguments with PF_additionalJavaRuntimeArguments
lhotari
requested review from
freeznet,
Technoboy-,
eolivelli,
nodece,
nicoloboschi and
coderzc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23130 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.93%
- Complexity 32624 34056 +1432
============================================
Files 1877 1919 +42
Lines 139502 144156 +4654
Branches 15299 15754 +455
============================================
+ Hits 102638 107408 +4770
+ Misses 28908 28519 -389
- Partials 7956 8229 +273
Flags with carried forward coverage won't be shown. Click here to find out more. |
Technoboy-
approved these changes
Aug 7, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 8, 2024
…ts with PF_additionalJavaRuntimeArguments env (apache#23130) (cherry picked from commit 8707fbe) (cherry picked from commit be0fca6)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 12, 2024
…ts with PF_additionalJavaRuntimeArguments env (apache#23130) (cherry picked from commit 8707fbe) (cherry picked from commit be0fca6)
Denovo1998
pushed a commit
to Denovo1998/pulsar
that referenced
this pull request
Aug 17, 2024
…ts with PF_additionalJavaRuntimeArguments env (apache#23130)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…ts with PF_additionalJavaRuntimeArguments env (apache#23130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Apache Pulsar Helm chart uses the gen-yml-from-env.py script to customize the function_worker.yml file so that environment variables are used to override values.
There's support missing for a few configuration keys.
Modifications
additionalJavaRuntimeArguments,additionalEnabledConnectorUrlPatternsandadditionalEnabledFunctionsUrlPatternsconfiguration keys as ones that take a list of values.Documentation
docdoc-requireddoc-not-neededdoc-complete