[improve] [broker] Avoid subscription fenced error with consumer.seek whenever possible #23163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y consumer.seek whenever possible
poorbarcode
added
category/reliability
lhotari
changed the title
lhotari
reviewed
Aug 13, 2024
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 13, 2024
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Aug 13, 2024
codelipenghui
approved these changes
Aug 13, 2024
Technoboy-
approved these changes
Aug 14, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
… whenever possible (apache#23163) (cherry picked from commit d5ce1ce) (cherry picked from commit bbe67c8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
… whenever possible (apache#23163) (cherry picked from commit d5ce1ce) (cherry picked from commit bbe67c8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2024
… whenever possible (apache#23163) (cherry picked from commit d5ce1ce) (cherry picked from commit bbe67c8)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
… whenever possible (apache#23163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After a consumer calls
seek, the operationreconnectwill get a fenced error, which leads to more unnecessary reconnects. The steps to produce are as follows:client-side: consumer connectedclient-side: callsconsumer.seekorseekAsyncbroker-side:fencedclient-side:reset cursornot finished yet.broker-side:reset cursoris completedclient-side: The consumer tries to reconnect, and it will finish at this time.Modifications
consumer.seekfenced other consumers under the same subscription.consumer.seekfenced other consumers under the same subscription. See the following example:broker-side: consumer_1broker-side: consumer_2falseconsumer_2reset cursorstartedfencedI do not want to improve the behavior above because it needs a lock. Since it does not cause critical errors, it just causes reconnection and the possibility of it occurring is low, we can leave it there.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x