[fix] [test] Revert the modification to NonDurableSubscriptionTest caused by a mistake in the PR#23129 #23168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used by a mistake in the PR#23129
4 tasks
lhotari
approved these changes
Aug 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23168 +/- ##
============================================
+ Coverage 73.57% 74.58% +1.00%
- Complexity 32624 33651 +1027
============================================
Files 1877 1920 +43
Lines 139502 144465 +4963
Branches 15299 15805 +506
============================================
+ Hits 102638 107742 +5104
+ Misses 28908 28470 -438
- Partials 7956 8253 +297
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I excluded changes to NonDurableSubscriptionTest when cherry-picking #23129 to branch-3.0 and branch-3.3 . Therefore there's no need to cherry-pick this PR to branch-3.0 and branch-3.3. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 20, 2024
…ParamsAutoClusterFailover (apache#23129) - excluding changes to pulsar-broker/src/test/java/org/apache/pulsar/client/api/NonDurableSubscriptionTest.java PR apache#23168 (cherry picked from commit 06a2f5c) (cherry picked from commit 286a5dc)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…used by a mistake in the PR#23129 (apache#23168)
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…used by a mistake in the PR#23129 (apache#23168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Modifications
There are no no-related changes in PR #23129, see the details https://github.com/apache/pulsar/pull/23129/files#r1716538209, the current PR is in order to revert the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x