[improve][broker] Support customized shadow managed ledger implementation #23179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion ### Motivation There is still an `instanceof` operation on `ShadowManagedLedgerImpl` in the main code, so users cannot implement their own shadow managed ledger. ### Modifications Replace the type check with the source topic check.
lhotari
approved these changes
Aug 15, 2024
hangc0276
reviewed
Aug 16, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
RobertIndie
approved these changes
Aug 16, 2024
hangc0276
approved these changes
Aug 16, 2024
|
Error in flaky test suite: |
|
Let me fix the failed tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23179 +/- ##
============================================
+ Coverage 73.57% 74.57% +1.00%
- Complexity 32624 33665 +1041
============================================
Files 1877 1921 +44
Lines 139502 144486 +4984
Branches 15299 15809 +510
============================================
+ Hits 102638 107754 +5116
+ Misses 28908 28480 -428
- Partials 7956 8252 +296
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
…tion (apache#23179) (cherry picked from commit 7f04364) (cherry picked from commit 4196195)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
…tion (apache#23179) (cherry picked from commit 7f04364) (cherry picked from commit 4196195)
15 tasks
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is still an
instanceofoperation onShadowManagedLedgerImplin the main code, so users cannot implement their own shadow managed ledger.Modifications
Replace the type check with the source topic check.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: