-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] Don't print info logs for each schema loaded by client #23206
Merged
BewareMyPower
merged 1 commit into
apache:master
from
BewareMyPower:bewaremypower/avro-log-debug
Aug 21, 2024
Merged
[improve][client] Don't print info logs for each schema loaded by client #23206
BewareMyPower
merged 1 commit into
apache:master
from
BewareMyPower:bewaremypower/avro-log-debug
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Currently when a client loads schema from brokers, it will print the whole schema as info logs. The broker's built-in client has the same issue so schemas will be printed in broker logs, which could be very long (hundreds of lines) and might expose user info. ### Modifications Reduce the log level to debug in `MultiVersionAvroReader`.
mattisonchao
approved these changes
Aug 21, 2024
poorbarcode
approved these changes
Aug 21, 2024
Demogorgon314
approved these changes
Aug 21, 2024
RobertIndie
approved these changes
Aug 21, 2024
thetumbled
approved these changes
Aug 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23206 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.93%
- Complexity 32624 33667 +1043
============================================
Files 1877 1918 +41
Lines 139502 144629 +5127
Branches 15299 15812 +513
============================================
+ Hits 102638 107758 +5120
+ Misses 28908 28616 -292
- Partials 7956 8255 +299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 22, 2024
…ent (apache#23206) (cherry picked from commit 66e1a06) (cherry picked from commit 06ebe2a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 23, 2024
…ent (apache#23206) (cherry picked from commit 66e1a06) (cherry picked from commit 06ebe2a)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.7
release/3.3.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when a client loads schema from brokers, it will print the whole schema as info logs. The broker's built-in client has the same issue so schemas will be printed in broker logs, which could be very long (hundreds of lines) and might expose user info.
Modifications
Reduce the log level to debug in
MultiVersionAvroReader
.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: