Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][client] Don't print info logs for each schema loaded by client #23206

Merged

Conversation

BewareMyPower
Copy link
Contributor

Motivation

Currently when a client loads schema from brokers, it will print the whole schema as info logs. The broker's built-in client has the same issue so schemas will be printed in broker logs, which could be very long (hundreds of lines) and might expose user info.

Modifications

Reduce the log level to debug in MultiVersionAvroReader.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

### Motivation

Currently when a client loads schema from brokers, it will print the
whole schema as info logs. The broker's built-in client has the same
issue so schemas will be printed in broker logs, which could be very
long (hundreds of lines) and might expose user info.

### Modifications

Reduce the log level to debug in `MultiVersionAvroReader`.
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.50%. Comparing base (bbc6224) to head (eaada3c).
Report is 540 commits behind head on master.

Files Patch % Lines
...ent/impl/schema/reader/MultiVersionAvroReader.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23206      +/-   ##
============================================
+ Coverage     73.57%   74.50%   +0.93%     
- Complexity    32624    33667    +1043     
============================================
  Files          1877     1918      +41     
  Lines        139502   144629    +5127     
  Branches      15299    15812     +513     
============================================
+ Hits         102638   107758    +5120     
+ Misses        28908    28616     -292     
- Partials       7956     8255     +299     
Flag Coverage Δ
inttests 27.94% <0.00%> (+3.36%) ⬆️
systests 24.67% <0.00%> (+0.34%) ⬆️
unittests 73.86% <0.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ent/impl/schema/reader/MultiVersionAvroReader.java 73.33% <0.00%> (+1.90%) ⬆️

... and 531 files with indirect coverage changes

@BewareMyPower BewareMyPower merged commit 66e1a06 into apache:master Aug 21, 2024
73 of 77 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/avro-log-debug branch August 21, 2024 06:18
lhotari pushed a commit that referenced this pull request Aug 21, 2024
lhotari pushed a commit that referenced this pull request Aug 21, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 22, 2024
…ent (apache#23206)

(cherry picked from commit 66e1a06)
(cherry picked from commit 06ebe2a)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Aug 23, 2024
…ent (apache#23206)

(cherry picked from commit 66e1a06)
(cherry picked from commit 06ebe2a)
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants