[improve] [broker] Part 2 of PIP-370: add metrics "pulsar_replication_disconnected_count" #23213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Aug 23, 2024
dao-jun
approved these changes
Aug 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23213 +/- ##
============================================
+ Coverage 73.57% 74.52% +0.94%
- Complexity 32624 34224 +1600
============================================
Files 1877 1922 +45
Lines 139502 144754 +5252
Branches 15299 15832 +533
============================================
+ Hits 102638 107874 +5236
+ Misses 28908 28622 -286
- Partials 7956 8258 +302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Fixed
Show fixed
Hide fixed
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Fixed
Show fixed
Hide fixed
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Fixed
Show fixed
Hide fixed
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java
Fixed
Show fixed
Hide fixed
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2024
…_disconnected_count" (apache#23213) (cherry picked from commit 09a16c2) (cherry picked from commit fbf5268)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2024
…_disconnected_count" (apache#23213) (cherry picked from commit 09a16c2) (cherry picked from commit fbf5268)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 28, 2024
…_disconnected_count" (apache#23213) (cherry picked from commit 09a16c2) (cherry picked from commit fbf5268)
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…_disconnected_count" (apache#23213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
see also PIP-370: configurable remote topic creation in geo-replication
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x