-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-368: Support lookup based on the lookup properties #23223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@RobertIndie Please add the following content to your PR description and select a checkbox:
|
…to prevent flakiness
BewareMyPower
approved these changes
Aug 27, 2024
RobertIndie
added
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
and removed
doc-label-missing
labels
Aug 27, 2024
github-actions
bot
added
doc-label-missing
and removed
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
labels
Aug 27, 2024
dao-jun
approved these changes
Aug 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23223 +/- ##
============================================
+ Coverage 73.57% 74.53% +0.95%
- Complexity 32624 34238 +1614
============================================
Files 1877 1922 +45
Lines 139502 144785 +5283
Branches 15299 15835 +536
============================================
+ Hits 102638 107913 +5275
+ Misses 28908 28595 -313
- Partials 7956 8277 +321
Flags with carried forward coverage won't be shown. Click here to find out more.
|
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
…apache#23223) PIP: apache#23075 ### Motivation This is the implementation for the PIP: apache#23075 Currently, the lookup process uses only the topic name as its parameter. However, to enhance this process, it's beneficial for clients to provide additional information. This could be done by introducing the `lookupProperties` field in the client configuration. Clients can then share these properties with the broker during lookup. On the broker side, the broker could also contain some properties that are used for the lookup. We can also support the lookupProperties for the broker. The broker can use these properties to make a better decision on which broker to return. Here is the rack-aware lookup scenario for using the client properties for the lookup: Assuming there are two brokers that broker-0 configures the lookup property "rack" with "A" and broker-1 configures the lookup property "rack" with "B". By using the lookup properties, clients can supply rack information during the lookup, enabling the broker to identify and connect them to the nearest broker within the same rack. If a client that configures the "rack" property with "A" connects to a lookup broker, the customized load manager can determine broker-0 as the owner broker since the broker and the client have the same rack property. ### Modifications - Add new configuration `lookupProperties` to the client. While looking up the broker, the client will send the properties to the broker through `CommandLookupTopic` request. - Add `properties` field to the `CommandLookupTopic`. - Add `lookupProperties` to the `LookupOptions`. The Load Manager implementation can access the `properties` through `LookupOptions` to make a better decision on which broker to return. - Introduce a new broker configuration `lookupPropertyPrefix`. Any broker configuration properties that start with the `lookupPropertyPrefix` will be included into the `BrokerLookupData` and be persisted in the metadata store. The broker can use these properties during the lookup. Co-authored-by: Yunze Xu <xyzinfernity@163.com>
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #23075
Motivation
This is the implementation for the PIP: #23075
Currently, the lookup process uses only the topic name as its parameter. However, to enhance this process, it's
beneficial for clients to provide additional information. This could be done by introducing the
lookupProperties
fieldin the client configuration. Clients can then share these properties with the broker during lookup.
On the broker side, the broker could also contain some properties that are used for the lookup. We can also support the
lookupProperties for the broker. The broker can use these properties to make a better decision on which broker to
return.
Here is the rack-aware lookup scenario for using the client properties for the lookup:
Assuming there are two brokers that broker-0 configures the lookup property "rack" with "A" and broker-1 configures the
lookup property "rack" with "B". By using the lookup properties, clients can supply rack information during the lookup,
enabling the broker to identify and connect them to the nearest broker within the same rack. If a client that configures
the "rack" property with "A" connects to a lookup broker, the customized load manager can determine broker-0 as the
owner broker since the broker and the client have the same rack property.
Modifications
lookupProperties
to the client. While looking up the broker, the client will send the propertiesto the broker through
CommandLookupTopic
request.properties
field to theCommandLookupTopic
.lookupProperties
to theLookupOptions
. The Load Manager implementation can accessthe
properties
throughLookupOptions
to make a better decision on which broker to return.lookupPropertyPrefix
. Any broker configuration properties that start with thelookupPropertyPrefix
will be included into the
BrokerLookupData
and be persisted in the metadata store. The broker can use these propertiesduring the lookup.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: RobertIndie#15
Co-authored-by: Yunze Xu xyzinfernity@163.com