[fix][test] Fix flaky GetPartitionMetadataMultiBrokerTest.testCompatibilityDifferentBrokersForNonPersistentTopic #23259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bilityDifferentBrokersForNonPersistentTopic
Technoboy-
reviewed
Sep 5, 2024
...broker/src/test/java/org/apache/pulsar/broker/admin/GetPartitionMetadataMultiBrokerTest.java
Show resolved
Hide resolved
|
@Technoboy- PLAT~ |
lhotari
added
type/flaky-tests
release/blocker
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23259 +/- ##
============================================
+ Coverage 73.57% 74.28% +0.70%
- Complexity 32624 34873 +2249
============================================
Files 1877 1949 +72
Lines 139502 146867 +7365
Branches 15299 16168 +869
============================================
+ Hits 102638 109094 +6456
- Misses 28908 29359 +451
- Partials 7956 8414 +458
Flags with carried forward coverage won't be shown. Click here to find out more. |
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
…bilityDifferentBrokersForNonPersistentTopic (apache#23259) (cherry picked from commit c891eaa) (cherry picked from commit cddb3ac)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
…bilityDifferentBrokersForNonPersistentTopic (apache#23259) (cherry picked from commit c891eaa) (cherry picked from commit cddb3ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The root cause of this problem is that the
getBrokermethod is asynchronous. When the methodgetLookupRequestPermitsis called, thelookupRequestSemaphoremay not have been released yet.Modifications
Wait for the
getBrokermethod to complete before continuingDocumentation
docdoc-requireddoc-not-neededdoc-complete