Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][schema] Improve Incompatible Schema Exception error message in ServerCnx.java #23344

Merged
merged 3 commits into from
Sep 25, 2024
Merged

[improve][schema] Improve Incompatible Schema Exception error message in ServerCnx.java #23344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
479fc04
Improved error message in serverCnx.java
nikam14 Sep 24, 2024
d5e9661
Update ServerCnx.java
nikam14 Sep 24, 2024
a134c67
typo fix
nikam14 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3052,7 +3052,8 @@ private CompletableFuture<SchemaVersion> tryAddSchema(Topic topic, SchemaData sc
CompletableFuture<SchemaVersion> result = new CompletableFuture<>();
if (hasSchema && (schemaValidationEnforced || topic.getSchemaValidationEnforced())) {
result.completeExceptionally(new IncompatibleSchemaException(
"Producers cannot connect or send message without a schema to topics with a schema"));
"Producers cannot connect or send message without a schema to topics with a schema"
+ "when SchemaValidationEnforced is enabled"));
} else {
result.complete(SchemaVersion.Empty);
}
Expand Down Expand Up @@ -3727,4 +3728,4 @@ public void incrementThrottleCount() {
public void decrementThrottleCount() {
throttleTracker.decrementThrottleCount();
}
}
}
Loading